i have an application where i have a cascading dropdown, a simple dropdown and a submit commandButton. i wish to show report in datatable by selecting various criteria from the dropdowns. all works fine except when i wish to select the criteria from child dropdown. it doesnt bind with its value in the managed bean(found that by debugging). here's my code: xhtml:
<h:outputText value="Exchange"/>
<p:selectOneMenu style="width: 150px" value="#{reportBean.exchange}">
<f:selectItem itemLabel="--select--" itemValue="--select--"/>
<f:selectItem itemLabel="NSE" itemValue="nse"/>
<f:selectItem itemLabel="BSE" itemValue="bse"/>
<p:ajax update="sym" listener="#{reportBean.wow}"/>
</p:selectOneMenu>
<h:outputText value="Scrip Symbol :"/>
<p:selectOneMenu value="#{reportBean.scripID}" id="sym" style="width: 100px">
<f:selectItem itemLabel="All" itemValue="0"/>
<f:selectItems var="scrip" value="#{reportBean.sl}" itemLabel="#{scrip.scripSymbol}" itemValue="#{scrip.scripID}"/>
</p:selectOneMenu>
<h:outputText value="Order Type :"/>
<p:selectOneMenu style="width: 100px" value="#{reportBean.orderType}">
<f:selectItem itemLabel="All" itemValue="All"/>
<f:selectItem itemLabel="Buy" itemValue="B"/>
<f:selectItem itemLabel="Sell" itemValue="S"/>
</p:selectOneMenu>
<p:commandButton ajax="true" update="dt" value="Submit" action="#{reportBean.getTradeByUserName()}" type="submit"/>
</h:panelGrid>
<p:dataTable id="dt" var="trade" widgetVar="scripTab"
emptyMessage="No trade found with given criteria"
value="#{reportBean.tradeList}"
paginator="true" paginatorTemplate="{CurrentPageReport} {FirstPageLink} {PreviousPageLink} {PageLinks} {NextPageLink} {LastPageLink}"
rowsPerPageTemplate="3,5,10" rows="3" >
<p:column>....
managed bean code:
public void wow()
{
sl=getAllScripByExchange(exchange);
}
public Integer getScripID() {
return scripID;
}
public void setScripID(Integer scripID) {
MasterScrip sm =getScripByID(scripID);
if(sm!=null)
this.scripSymbol=sm.getScripSymbol();
this.scripID = scripID;
}
public List<TradeStock> getTradeList() {
return tradeList;
}
public void setTradeList(List<TradeStock> tradeList) {
this.tradeList = tradeList;
}
public List<service.TradeStock> getTradeByUserName()
{
HttpServletRequest request = (HttpServletRequest)FacesContext.getCurrentInstance().getExternalContext().getRequest();
HttpSession session = request.getSession(true);
String uname = session.getAttribute("uname").toString();
tradeList= getTradeReport(scripID, uname, exchange, orderType);
return tradeList;
}
bean method:
@Override
public Collection<TradeStock> getTradeReport(Integer scripID, String uname, String exchange, String tradeType) {
String strQuery = null;
strQuery = "Select t from TradeStock t where t.userName.userName = :userName ";
if(! exchange.equalsIgnoreCase("All"))
{
strQuery += " and t.scripID.exchange = '" + exchange + "'";
}
if(scripID>0)
{
strQuery += " and t.scripID.scripID = " + scripID;
}
if(! tradeType.equalsIgnoreCase("All"))
{
strQuery += " and t.orderID.buySell = '" + tradeType + "'";
}
Collection<TradeStock> c = em.createQuery(strQuery).setParameter("userName",uname).getResultList();
return c;
}
why does the value not bind to the bean props? how do i solve it?(the matter of my concern is that the same code worked yesterday but today when i ran the same code it started troubling me).
edited:faces-config
<faces-config version="2.0"
xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd">
<managed-bean>
<managed-bean-name>userReportBean</managed-bean-name>
<managed-bean-class>UserReportBean</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>
<navigation-rule>
<from-view-id>/adminpages/editScrip.xhtml</from-view-id>
<navigation-case>
<from-action>#{manageScrip.updateScrip}</from-action>
<from-outcome>success</from-outcome>
<to-view-id>/adminpages/manageScrip.xhtml</to-view-id>
</navigation-case>
</navigation-rule>
<navigation-rule>
<from-view-id>/adminpages/addScrip.xhtml</from-view-id>
<navigation-case>
<from-action>#{manageScrip.addScrip}</from-action>
<from-outcome>success</from-outcome>
<to-view-id>/adminpages/manageScrip.xhtml</to-view-id>
</navigation-case>
</navigation-rule>
<navigation-rule>
<from-view-id>/adminpages/manageScrip.xhtml</from-view-id>
<navigation-case>
<from-action>#{manageScrip.returnEdit}</from-action>
<from-outcome>success</from-outcome>
<to-view-id>/adminpages/editScrip.xhtml</to-view-id>
</navigation-case>
</navigation-rule>
<managed-bean>
<managed-bean-name>equityBean</managed-bean-name>
<managed-bean-class>beans.equityBean</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>
<managed-bean>
<managed-bean-name>reportBean</managed-bean-name>
<managed-bean-class>beans.reportBean</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>
</faces-config>
That can happen if the managed bean is been placed in the request scope by @RequestScoped
. Every single HTTP request, including Ajax requests, would create a completely brand new instance of the bean, with all properties set to default. This way the <f:selectItems>
list becomes empty and hence there's no value to set in the model.
Placing the bean in the view scope by @ViewScoped
should solve this problem.
Update: you should remove those <managed-bean>
definitions from faces-config.xml
. That was a leftover from old JSF 1.x way of registering beans. They would only override the JSF 2.x way of @ManagedBean
configurations.
Not directly related to your concrete problem, but those <navigation-case>
entries are superfluous in JSF 2.x. Perhaps you were incorrectly reading old JSF 1.x books/tutorials/resources instead of JSF 2.x ones?
Unrelated to the concrete problem, you've there seriously a SQL injection attack hole in getTradeReport()
method. You should never string-concatenate user-controlled variables in a SQL/JPQL string. Use parameterized queries with setParameter()
instead. See also CSRF, XSS and SQL Injection attack prevention in JSF.