Hi I'm a total newbie with php and i'm trying to get this current PHP text hit counter script from phpjunkyard.com to automatically generate counters for dynamic pages without me having to create a counter.txt file for every pages. so far i mange to get it to write a new .txt for every new page if it does not exist but i'm getting an error and i don't know how to remove it.. PS: I'm use this counter because it has unique visitor counting system.
this is the original full PHP file:
<?php
/*******************************************************************************
* Title: PHP hit counter (PHPcount)
* Version: 1.4 @ March 3, 2012
* Author: Klemen Stirn
* Website: http://www.phpjunkyard.com
********************************************************************************
* COPYRIGHT NOTICE
* Copyright 2004-2012 Klemen Stirn. All Rights Reserved.
*
* This script may be used and modified free of charge by anyone
* AS LONG AS COPYRIGHT NOTICES AND ALL THE COMMENTS REMAIN INTACT.
* By using this code you agree to indemnify Klemen Stirn from any
* liability that might arise from it's use.
*
* Selling the code for this program, in part or full, without prior
* written consent is expressly forbidden.
*
* Obtain permission before redistributing this software over the Internet
* or in any other medium. In all cases copyright and header must remain
* intact. This Copyright is in full effect in any country that has
* International Trade Agreements with the United States of America or
* with the European Union.
********************************************************************************
*
* ACKNOWLEDGEMENT
*
* Please support future script development by linking to us:
* http://www.phpjunkyard.com/about/link2us.php
*
* Or by sending a small donation:
* http://www.phpjunkyard.com/about/donate.php
*
*******************************************************************************/
// SETUP YOUR COUNTER
// See file readme.html for detailed instructions
// Count unique visitors? 1 = YES, 0 = NO
$count_unique = 0;
// Number of hours a visitor is considered as "unique"
$unique_hours = 24;
// Minimum number of digits shown (zero-padding). Set to 0 to disable.
$min_digits = 0;
#############################
# DO NOT EDIT BELOW #
#############################
/* Turn error notices off */
error_reporting(E_ALL ^ E_NOTICE);
/* Tell browsers not to cache the file output so we can count all hits */
header("Cache-Control: no-store, no-cache, must-revalidate");
header("Cache-Control: post-check=0, pre-check=0", false);
header("Pragma: no-cache");
/* Is page ID set? */
if ( ! isset($_GET['page']) )
{
die('ERROR: The counter.php file must be called with a <b>?page=PAGEID</b> parameter, for example <b>counter.php?page=test</b>');
}
/* Remove any illegal chars from the page ID */
$page = preg_replace('/[^a-zA-Z0-9\-_\.]/','',$_GET['page']);
/* Stop if $page is not valid */
if ( ! strlen($page) )
{
die('ERROR: Page ID is missing or contains only invalid chars. Please use only these chars for the page ID: a-z, A-Z, 0-9, ".", "-" and "_"');
}
/* Set values for cookie and log file names */
$cname = 'tcount_unique_'.$page;
$logfile = 'logs/' . $page . '.txt';
/* Does the log file exist? */
if ( ! file_exists($logfile) )
{
die('ERROR: Log file not found. Make sure there is a file called <b>' . $page . '.txt</b> inside your <b>logs</b> folder. On most servers file names are CaSe SeNSiTiVe!');
}
/* Open log file for reading and writing */
if ($fp = @fopen($logfile, 'r+'))
{
/* Lock log file from other scripts */
$locked = flock($fp, LOCK_EX);
/* Lock successful? */
if ($locked)
{
/* Let's read current count */
$count = intval( trim( fread($fp, filesize($logfile) ) ) );
/* If counting unique hits is enabled make sure it's a unique hit */
if ( $count_unique == 0 || ! isset($_COOKIE[$cname]) )
{
/* Update count by 1 and write the new value to the log file */
$count = $count + 1;
rewind($fp);
fwrite($fp, $count);
/* Print the Cookie and P3P compact privacy policy */
header('P3P: CP="NOI NID"');
setcookie($cname, 1, time()+60*60*$unique_hours);
}
}
else
{
/* Lock not successful. Better to ignore than to damage the log file */
$count = 1;
}
/* Release file lock and close file handle */
flock($fp, LOCK_UN);
fclose($fp);
}
else
{
die("ERROR: Can't read/write to the log file ($logfile). Make sure this file is writable by PHP scripts. On UNIX servers, CHMOD the log file to 666 (rw-rw-rw-).");
}
/* Is zero-padding enabled? If yes, add zeros if required */
if ($min_digits)
{
$count = sprintf('%0'.$min_digits.'s', $count);
}
/* Print out Javascript code and exit */
echo 'document.write(\''.$count.'\');';
exit();
?>
And this is what i changed (at line 82):
From:
/* Does the log file exist? */
if ( ! file_exists($logfile) )
{
die('ERROR: Log file not found. Make sure there is a file called <b>' . $page . '.txt</b> inside your <b>logs</b> folder. On most servers file names are CaSe SeNSiTiVe!');
}
To:
/* Does the log file exist? */
if ( ! file_exists($logfile) )
{
fopen($logfile, 'w') or die("can't open file");
}
So it created a new counter with the .txt for every different page by id like:
<script language="Javascript" src="http://www.website.com/counter.php?page=<?php echo $pageid();?>">
But this is the error i'm getting when on a new id only on the first time when it's creating the .txt file:
Warning: fread() [function.fread]: Length parameter must be greater than 0 in /home/u716430538/public_html/counter14/counter.php on line 95
document.write('1');
after then if you open back that same id it will show like normal:
document.write('1');
Sorry for my bad English, hope someone can help me. Thanks
Try this:
/* Does the log file exist? */
if ( ! file_exists($logfile) )
{
$f = fopen($logfile, 'w') or die("can't open file");
fwrite($f,"0");
}