[SOLVED] Converting LPBYTE into String

Converting LPBYTE into String

I'm querying data from the registry and it's being outputted as LPBYTE, and this is where i'm stuck. I need to convert the LPBYTE into a type of data that I can manipulate such as a String.

This is my code so far

HKEY hk;
string poolID;
DWORD dwSize     = 0;
DWORD dwDataType = 0;
DWORD dwValue;
LPBYTE lpValue   = NULL;
CA2W registryLocation("Software\\Example");
// Check registry if exists, otherwise create.
LONG openReg = RegOpenKeyEx(HKEY_CURRENT_USER, registryLocation, 0, KEY_QUERY_VALUE, &hk);
if (openReg==ERROR_SUCCESS) {  } else { cout << "Error (Could not open/create Registry Location)\n"; }
// Get buffer size
LONG getRegBuf = RegQueryValueExA(hk, "", 0, &dwDataType, lpValue, &dwSize);
if (getRegBuf==ERROR_SUCCESS) { cout << "Got reg key buf size\n"; } else { cout << "Error (registry key does not exist)/n"; intro(); }
lpValue = (LPBYTE)malloc(dwSize);
// Open reg value
LONG getReg = RegQueryValueExA(hk, "", 0, &dwDataType, (LPBYTE)&dwValue, &dwSize);
if (getReg==ERROR_SUCCESS) { cout << "Successful\n"; } else { cout << "Error\n"; }
cout << dwValue;

Any help or code examples will be much appreciated.

Solution

You need to declare lpValue to be char*.

char* lpValue;

Then allocate it with a call to new.

lpValue = new char[dwSize+1];

Allocate an extra element in case the registry data is mal-formed and is missing a null-terminator. That is something that can happen. Then set the last element to \0:

lpValue[dwSize] = '\0';

Then get the value:

LONG getReg = RegQueryValueExA(..., (LPBYTE)&dwValue, ...);

Deallocate using delete[]:

delete[] lpValue;