schemeracketracket-student-languages

Why is this expression giving me a function body error?


(define (subtract-1 n)
  (string-append "Number is: " (number->string n))
  (cond
    [(= n 0) "All done!"]
    [else (subtract-1(- n 1))]))

I keep getting the error: define: expected only one expression for the function body, but found 1 extra part. I'm not understanding why I'm getting this.

NOTE TO SELF: When using DrRacket, Setting the language to BSL may make Racket commands error at compile time.


Solution

  • The language you're using (BSL) only allows a single expression inside the body of a procedure, if there's more than one expression, you need to pack them inside a begin.

    Also notice that the string-append line is doing nothing, you should print it or accumulate it. Here's a possible solution with my recommendations in place:

    (define (subtract-1 n)
      (begin
        (display (string-append "Number is: " (number->string n) "\n"))
        (cond
          [(= n 0) "All done!"]
          [else (subtract-1 (- n 1))])))
    

    Even better, use the printf procedure for simplicity's sake:

    (define (subtract-1 n)
      (begin
        (printf "~a ~s~n" "Number is:" n)
        (cond
          [(= n 0) "All done!"]
          [else (subtract-1 (- n 1))])))
    

    Either way a sample execution looks like this:

    (subtract-1 3)
    => Number is: 3
    => Number is: 2
    => Number is: 1
    => Number is: 0
    => "All done!"