djangodjango-1.5django-profiles

Django custom user model: How to manage staff permissions?


I'm trying to benefit from Django 1.5 and created custom user model. In order to use builtin permissions, which I would like to limit access with in the admin interface. I inherited my user class also from PermissionMixin. But when I create new user and check Staff box, the new user gets all the access that superuser has.

What am I doing wrong?

models.py

class MyUserManager(BaseUserManager):
    def create_user(self, email, password=None):
        if not email:
            raise ValueError(_('Users must have an email address'))
        user = self.model(email=MyUserManager.normalize_email(email),)
        user.set_password(password)
        user.save(using=self._db)
        return user

    def create_superuser(self, email, password):
        user = self.create_user(email, password=password,)
        user.is_superuser = True
        user.is_staff = True
        user.save(using=self._db)
        return user


class MyUser(AbstractBaseUser, PermissionsMixin):
    email = models.EmailField(unique=True, db_index=True,)
    is_active = models.BooleanField(_('active'), default=True,
        help_text=_('Designates whether this user should be treated as '
                    'active. Unselect this instead of deleting accounts.'))
    is_staff = models.BooleanField(_('staff status'), default=False,
        help_text=_('Designates whether the user can log into this admin site.'))

    objects = MyUserManager()
    USERNAME_FIELD = 'email'

Solution

  • I've rewritten custom user model. The main difference from the django user model now is that mine does not have username field. Here is the code:

    import warnings
    from django.core.exceptions import ImproperlyConfigured
    from django.core.mail import send_mail
    from django.db import models
    from django.contrib.auth.models import AbstractBaseUser, PermissionsMixin,\
        SiteProfileNotAvailable, BaseUserManager
    from django.utils import timezone
    from django.utils.http import urlquote
    from django.utils.translation import ugettext_lazy as _
    
    
    class CustomUserManager(BaseUserManager):
        def create_user(self, email=None, password=None, **extra_fields):
            """
            Creates and saves a User with the given email and password.
            """
            now = timezone.now()
            if not email:
                raise ValueError('The given email must be set')
            email = CustomUserManager.normalize_email(email)
            user = self.model(email=email,
                              is_staff=False, is_active=True, is_superuser=False,
                              last_login=now, date_joined=now, **extra_fields)
    
            user.set_password(password)
            user.save(using=self._db)
            return user
    
        def create_superuser(self, email, password, **extra_fields):
            u = self.create_user(email, password, **extra_fields)
            u.is_staff = True
            u.is_active = True
            u.is_superuser = True
            u.save(using=self._db)
            return u
    
    
    class CustomUser(AbstractBaseUser, PermissionsMixin):
        email = models.EmailField(_('email address'), unique=True)
        first_name = models.CharField(_('first name'), max_length=30, blank=True)
        middle_name = models.CharField(_('middle name'), max_length=30, blank=True)
        last_name = models.CharField(_('last name'), max_length=30, blank=True)
        is_staff = models.BooleanField(_('staff status'), default=False,
            help_text=_('Designates whether the user can log into this admin '
                        'site.'))
        is_active = models.BooleanField(_('active'), default=True,
            help_text=_('Designates whether this user should be treated as '
                        'active. Unselect this instead of deleting accounts.'))
        date_joined = models.DateTimeField(_('date joined'), default=timezone.now)
    
        objects = CustomUserManager()
    
        USERNAME_FIELD = 'email'
    
        def get_absolute_url(self):
            return "/users/%s/" % urlquote(self.username)
    
        def get_full_name(self):
            """
            Returns the first_name plus the last_name, with a space in between.
            """
            full_name = '%s %s' % (self.first_name, self.last_name)
            return full_name.strip()
    
        def get_short_name(self):
            "Returns the short name for the user."
            return self.first_name
    
        def email_user(self, subject, message, from_email=None):
            """
            Sends an email to this User.
            """
            send_mail(subject, message, from_email, [self.email])
    
        def get_profile(self):
            """
            Returns site-specific profile for this user. Raises
            SiteProfileNotAvailable if this site does not allow profiles.
            """
            warnings.warn("The use of AUTH_PROFILE_MODULE to define user profiles"
                          " has been deprecated.",
                PendingDeprecationWarning)
            if not hasattr(self, '_profile_cache'):
                from django.conf import settings
                if not getattr(settings, 'AUTH_PROFILE_MODULE', False):
                    raise SiteProfileNotAvailable(
                        'You need to set AUTH_PROFILE_MODULE in your project '
                        'settings')
                try:
                    app_label, model_name = settings.AUTH_PROFILE_MODULE.split('.')
                except ValueError:
                    raise SiteProfileNotAvailable(
                        'app_label and model_name should be separated by a dot in '
                        'the AUTH_PROFILE_MODULE setting')
                try:
                    model = models.get_model(app_label, model_name)
                    if model is None:
                        raise SiteProfileNotAvailable(
                            'Unable to load the profile model, check '
                            'AUTH_PROFILE_MODULE in your project settings')
                    self._profile_cache = model._default_manager.using(
                                       self._state.db).get(user__id__exact=self.id)
                    self._profile_cache.user = self
                except (ImportError, ImproperlyConfigured):
                    raise SiteProfileNotAvailable
            return self._profile_cache
    

    Now it works and keeps all default permissions. Also note, that for the admin you must rewrite user ModelAdmin and UserCreationForm along with UserChangeForm classes.