javaarraysapache-commons-lang

Javadoc of ArrayUtils.isNotEmpty is faulty?

The javadoc of ArrayUtils.isNotEmpty() in Apache Commons Lang seems to be wrong. Or, at least, misleading. It says

Returns: true if the array is not empty or not null

In my understanding, an empty array is not null. So, according to the above definition, isNotEmpty() should return true for an empty array, which is counterintuitive.

Wouldn't

Returns: true if the array is not null and not empty

be more correct?

Solution

  • Wouldn't

    Returns: true if the array is not null and not empty

    be more correct?

    Yes you are right. The doc is a bit misleading. In fact, if you see the source code, it does exactly that:

    public static boolean isNotEmpty(Object[] array) {
   return (array != null && array.length != 0);
}