androidnetworkonmainthreadthread-exceptions

android.os.NetworkOnMainThreadException while posting data to url


In the below code I'm getting an error when running my Android project

Code:

  try {                 
        Gson gson = new Gson();
        String json = gson.toJson(stockDetailData);
        String json1 = gson.toJson(stockMainData); 
        String json2 = gson.toJson(pledgerData);
        JSONObject jo = new JSONObject();                   

        jo.put("stockDetailData", json.toString());
        jo.put("stockMainData", json1.toString());
        jo.put("pledgerData", json2.toString());
        jo.put("company_id", "4");



        URL url = new URL("http://127.0.0.1:180/AfaqTraders/index.php/sale/saveVoucher");

        HttpClient httpClient = new DefaultHttpClient();
        HttpPost httpPost = new HttpPost(url.toURI());

        // Prepare JSON to send by setting the entity
        httpPost.setEntity(new StringEntity(jo.toString(), "UTF-8"));

        // Set up the header types needed to properly transfer JSON
        httpPost.setHeader("Content-Type", "application/json");
        httpPost.setHeader("Accept-Encoding", "application/json");
        httpPost.setHeader("Accept-Language", "en-US");

        // Execute POST
        HttpResponse response = httpClient.execute(httpPost);                   
    } catch(Exception e) {
        Toast.makeText(getApplicationContext(), e.getMessage(), Toast.LENGTH_LONG).show();
    }

Error: android.os.NetworkOnMainThreadException

I have been looking for the error but I'm unable to find it. Can anybody tell me what I'm doing wrong here??


Solution

  • Its because you're doing network operation on Main UI thread

    if you're using threads to do network operations then you can use this code snippet

    if (android.os.Build.VERSION.SDK_INT > 9) {
    StrictMode.ThreadPolicy policy = 
            new StrictMode.ThreadPolicy.Builder().permitAll().build();
    StrictMode.setThreadPolicy(policy);
    }
    

    in your OnCreate()

    But its wrong practice to use above said operation, instead you should use AsyncTask class provided by android to handle properly network operation without blocking UI thread.

    you can learn more by visiting this LINK

    or can use the below code

    private class UploadFiles extends AsyncTask<String, Void, Void> {
         protected String doInBackground(String... urls) {
             //THIS METHOD WILL BE CALLED AFTER ONPREEXECUTE
             //YOUR NETWORK OPERATION HERE
             return null;
         }
    
         protected void onPreExecute() {
             super.onPreExecute();
             //THIS METHOD WILL BE CALLED FIRST
             //DO OPERATION LIKE SHOWING PROGRESS DIALOG PRIOR TO BEGIN NETWORK OPERATION
         }
    
         protected void onPostExecute(String result) {
             super.onPostExecute();
             //TNIS METHOD WILL BE CALLED AT LAST AFTER DOINBACKGROUND
             //DO OPERATION LIKE UPDATING UI HERE
         }
     }
    

    and you can simple call this class by writing

     new UploadFiles ().execute(new String[]{//YOUR LINK});