[SOLVED] Differences between v1.8 and 1.10 when disabling gutters on BorderContainer

Differences between v1.8 and 1.10 when disabling gutters on BorderContainer

I recently changed from 1.8 to 1.10.

When setting gutters="false" or data-dojo-props="gutters:false" in declarative creation it won`t hide the gutters.

When I set the gutters property in the bordercontainer source to false it still shows the gutters.

All dojo examples refer to gutters=true, and all google results refer to older versions.

Edit:

In 1.8 setting `gutters=false` also removed client borders and padding around bordercontainer.
In 1.10 it only removes the "gap" between the clients. Is there a setting to get the same results, or should I hack with css / styles?

Solution

You're actually relying on a bug. The visual elements should still be visible, even when using gutters: false. This bug has been fixed recently, as you can see in ticket #17966 and the commit by Bill.

What happened was that the baseClass of the BorderContainer was being overridden when disabling gutters. Because the baseClass was altered, the CSS didn't apply anymore, so the visual elements were removed (that's what you expected).

By disabling the splitters, you no longer get the gutter, as you can see in this demonstration: http://jsfiddle.net/HT3PJ/. However, the border around the BorderContainer remains, which makes sense (it is a BorderContainer after all).

However, if you're interested in this (buggy) behavior, you can always apply it by yourself by adding a class="noBorder" attribute to your BorderContainer and by adding the following CSS:

.noBorder.dijitBorderContainer .dijitBorderContainer-child {
    border: none;
    padding: 0;
}

The result will be similar to how it was before, as you can see in this demonstration: http://jsfiddle.net/w9ACq/1/