androidsqliteheap-memoryheap-size

StringBuilder exceeds memory - heap size(16 mib)


I have an application that requires a big SQLite database within it, now as I add rows to the tables when the heap size of my emulator is 16 MiB, it crashes down saying outofmemory, 32 MiB works fine. and I use a stringbuilder for GET.

So what can I do at this point? Is there a way to limit my application to be used on certain phones with certain heap sizes? If so specially, how can that be done?

Thanks in advance, here's my error code:

09-02 13:21:08.805: E/AndroidRuntime(482): FATAL EXCEPTION: AsyncTask #1
09-02 13:21:08.805: E/AndroidRuntime(482): java.lang.RuntimeException: An error occured while executing doInBackground()
09-02 13:21:08.805: E/AndroidRuntime(482):  at android.os.AsyncTask$3.done(AsyncTask.java:200)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.FutureTask.setException(FutureTask.java:124)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.FutureTask.run(FutureTask.java:137)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.lang.Thread.run(Thread.java:1096)
09-02 13:21:08.805: E/AndroidRuntime(482): Caused by: java.lang.OutOfMemoryError
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.lang.AbstractStringBuilder.enlargeBuffer(AbstractStringBuilder.java:97)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.lang.AbstractStringBuilder.append0(AbstractStringBuilder.java:136)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.lang.StringBuilder.append(StringBuilder.java:272)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.io.BufferedReader.readLine(BufferedReader.java:452)
09-02 13:21:08.805: E/AndroidRuntime(482):  at com.ex.nok.Src.prodGet(Src.java:157)
09-02 13:21:08.805: E/AndroidRuntime(482):  at com.ex.nok.MainActivity$RestRequ.doInBackground(MainActivity.java:398)
09-02 13:21:08.805: E/AndroidRuntime(482):  at com.ex.nok.MainActivity$RestRequ.doInBackground(MainActivity.java:1)
09-02 13:21:08.805: E/AndroidRuntime(482):  at android.os.AsyncTask$2.call(AsyncTask.java:185)
09-02 13:21:08.805: E/AndroidRuntime(482):  at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
09-02 13:21:08.805: E/AndroidRuntime(482):  ... 4 more

here's where my stringbuilder is, which causes the problem:

public static void prodGet (Activity act, String urlStr) {

    int productId;
    String productName;

    UrunSQLiteHelper dbProds = new UrunSQLiteHelper(act);

    HttpURLConnection conn = null;
    BufferedReader rd = null;
    try {
        URL url = new URL(urlStr);
        conn = (HttpURLConnection) url.openConnection();
        conn.setConnectTimeout(6000);
        conn.setReadTimeout(10000);
        if (conn.getResponseCode() >= 200 && conn.getResponseCode() < 300) {
            rd = new BufferedReader(new InputStreamReader(conn.getInputStream()));
            String line;
            while ((line = rd.readLine()) != null) { //<<<<<<

                if (line != null || line.length() != 0) {
                JSONTokener prodTokener = new JSONTokener(line);
                JSONArray prodArray = new JSONArray(prodTokener);

                for(int h=0; h<(prodArray.length()); h++)
                {
                    JSONObject json_obj_prd = prodArray.getJSONObject(h);
                    productId = json_obj_prd.getString("PRODID");
                    productName = json_obj_prd.getString("PRODNAME");

                    dbProds.addProduct(new Product(productId, productName));
                }

                dbProds.close();
                }
            }
            rd.close();

            conn.disconnect();

        }
        else {
        }
    }
    catch (Exception e) {
        Log.e("APP", "exception", e);
    }
    finally {
        if (rd != null) {
            try {
                rd.close();
            } catch (IOException e) {
            }
        }
        if (conn != null) {
            conn.disconnect();
        }
    }
}

Solution

  • Try JsonReader instead BufferedReader

    JsonReader reader = new JsonReader(new InputStreamReader(in, "UTF-8"));
    

    JsonReader javadoc provides nice example how to implement it properly.

    Alternatively, you can use 3rd party libraries like GSON or Jackson.