gitgerritgit-review

Error while submitting code to gerrit using git-review on windows


I get an error when I try to submit my code to gerrit using gitbash on windows. The error is as below:

$ git review
You are about to submit multiple commits. This is expected if you are
submitting a commit that is dependent on one or more in-review
commits. Otherwise you should consider squashing your changes into one
commit before submitting.
Traceback (most recent call last):
  File "c:\Python33\Scripts\git-review-script.py", line 9, in <module>
    load_entry_point('git-review==1.24', 'console_scripts', 'git-review')()
  File "C:\Python33\lib\site-packages\git_review\cmd.py", line 1214, in main
    assert_one_change(remote, branch, yes, have_hook)
  File "C:\Python33\lib\site-packages\git_review\cmd.py", line 718, in assert_on
e_change
    "Do you really want to submit the above commits?" % output)
  File "C:\Python33\lib\encodings\cp850.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_map)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u2026' in position
8042: character maps to <undefined>

The process aborts post the error message. Also the git-review version is as below:

$ git review --version
git-review-script.py version 1.24

Also the git version on my windows machine is:

git version 1.9.4.msysgit.1

I badly need help or any clue on how to get this working.

The character encoding showing on my cmd.exe is 850


Solution

  • Try to install Python 2.7.* and launch git review with it. I also had problems with running git-review on Python 3.* although authors claim that it is supported.


    By investigating your problem in detail I noticed that the problem is with \u2026 character (that is horizontal ellipsis - …). Python is known to have problems with decoding it.

    As a temporary fix, please reword your commit messages not to contain problematic characters (replace … with three dots).

    You may also use command git review -y to skip displaying the confirmation (thus the error message too).


    I have created a bug report for git-review.