gitgithubmergeatlassian-crucible

Is there a way to track pre-merged and post-merged code review for a branch in Atlassian Crucible


Our team has recently migrated to Atlassian Crucible for our peer reviews. The workflow we currently have in place is

The issue we are facing with this particular workflow is that once i have merged the branch back to develop and pushed it to origin crucible reports show these changes to develop as changes which have gone in without any reviews. So somehow these changes are not being traced back to code review we had on the feature branch. I am almost certain we are missing something in our workflow and would love to hear from the experts and rectify that.

Thanks in advance.


Solution

  • Can you explain this in more detail please? When you refer to Crucible reports do you mean review coverage report, http://FISHEYE_URL/plugins/servlet/review-coverage/REPO_NAME? What commits are marked as unreviewed, just the merge commits, or the actual commits made on the feature branch? In the former case this is the issue: https://jira.atlassian.com/browse/CRUC-6701 you may want to vote on and watch to get notified when that's resolved. In the latter case, does it happen because someone perhaps rebased commits from the feature branch when merging them into the development branch? Crucible at the moment won't detect follow up rebased commits I'm afraid. Instead those would be processed as unreviewed brand new commits.
    Hope that helps, let me know if you have further questions. Kind regards,