If I create my own thread (i.e. not a threadpool) and somewhere I call sleep
or any other interruptible method, is it ok to ignore the InterruptedException if I know nobody else in the code is doing an interrupt on the thread.
In other words, if the thread is supposed to live as long as the JVM, meaning the thread is not interruptible, is it safe to assume that InterruptedException will never be called and therefore the exception can be swallowed?
Ignoring a checked exception is never considered to be safe.
It may seem okay for you at the moment, but if any other programmer uses your code/API, they should expect the standard behaviour:
Which is, the thread "reacting" to an interrupt call, but with whatever "reaction" the thread's documentation describes.
I mean it's up to the thread's developer to both decide and document exactly how a thread handles an interrupt, and Java has not any pre-defined rule, but you should document your thread's "reaction" (with Documentation comments).
For example, the InterruptedException
is only thrown from blocking methods (like Thread.sleep(...)
), but never from normal lines of code (meaning the interrupt is simply ignored by default), which allows developers to choose (and document) thread's reaction, like:
Which takes time for development, if not already supported.
Thread.currentThread().interrupt()
in catch-block.Which simulates interrupt happening while normal code was running.
java.lang.Error
(or sub-class), and passing InterruptedException
-instance as cause
.Which unless documented, is least desired or expected.
To explain postpone; An empty catch block is dangerous with InterruptedException
, since the JVM removes the interrupted flag, and it should definitely be set again in the catch block, like:
try {
Thread.sleep(1000);
} catch (InterruptedException ignored) {
Thread.currentThread().interrupt();
}
In my opinion, this is the minimum catch implementation for InterruptedException
s. Checking for the isInterrupted
flag in a loop doesn't hurt much, either.
It is little overhead compared to your future programmer self's hassle searching a day or two for unexpected thread behaviour as you project may have grown a bit.
If you feel that your code's readability suffers from those catch implementations, you may implement your own safeSleep
utility method, which takes care of the Exception
s and sets the flag properly.
On the other hand, InterruptedException
is not thrown by the JVM itself in case of a hardware failure, it is a user indicated Exception
only. So, if you do not propagate your That's it technically. But you shouldn't underestimate the human factor and your programs evolution.Thread
s reference, there won't be any other Thread
s that are able to call Thread.interrupt()
on it.
Edit: As ruakh pointed out, there actually is a way to get a Thread
s reference and thus to schedule an Thread.interrupt()
call. That way the developer in heat may not even have to look at the class, that implements your uninterruptible Thread
. In my opinion that's even another reason, to implement proper exception handling.
Another thing: If you're not throwing an Exception
, logging such an event on a level beyond INFO
may be a good choice.