c++compilationundefinedabstract-type

Undefined reference on function operator>>


I'm defining a Abstract data type, when I started to define operators, I'm getting this error, do not understand why other similar projects my operators work and not on this one.

EventoHistorico.h

#ifndef __EVENTO
#define __EVENTO

#include <iostream>
#include <string>
#include <vector>

using namespace std;

/**
  * @file EventoHistorico.h
  * @brief T.D.A. EventoHistorico
  *
  * The instance of @e c its Abstract data type @c EventoHistorico is an object
  * that contains a date and a colection of events associated with that date
  *
  * Representation:
  * "date" : <"event1","event2",...>
  *
  * Examples:
  * "1924 : Greed, Sherlock Jr., The Sea Hawk ,The Last Laugh"
  * "1945 : Merge sort developed by John von Neumann"
  *
  *
  */

    string anio;

    vector<string> eventos;

    vector<string> GetEvents();


    friend istream& operator>> (istream& is, EventoHistorico& EH);



};
#endif

On my EventoHistorico.cpp I have the implementation of this function:

istream& operator>> (istream is, EventoHistorico& EH)
{
    // Obtenemos el primer año y la asignamos a la variable
    // (utilizamos como separador #)
    getline(is, EH.anio, '#');

    // Bandera para salir del bucle cuando se llegue al salto de linea
    // se utiliza este sistema para no usar break
    bool salir = false;

    // Recorre
    while (!salir && is)
    {
        string event;

        getline(is, event, '#');

        EH.eventos.push_back(event);

        //Si salto de linea
        if(is.peek() == '\n')
        {
            //Obtenemos el siguiente caracter (salto) y salimos del bucle
            is.get();
            salir=true;
        }
    }
    //referencia istream
    return is;

}

Then when I compile this proyect im getting this error

src/EventoHistorico.cpp: In function ‘std::istream& operator>>(std::istream, EventoHistorico&)’:
src/EventoHistorico.cpp:19:10: warning: reference to local variable ‘is’ returned [-Wreturn-local-addr]
 istream& operator>> (istream is, EventoHistorico& EH)
          ^
g++ -o bin/pruebacronologia obj/cronologia.o obj/pruebacronologia.o obj/EventoHistorico.o 
obj/cronologia.o: On function `operator>>(std::istream&, Cronologia&)':
/home/antonio/Escritorio/TDA/cronologia/src/cronologia.cpp:32: reference to `operator>>(std::istream&, EventoHistorico&)' undefined
collect2: error: ld returned 1 exit status
make: *** [bin/pruebacronologia] Error 1

Solution

  • Change this...

    istream& operator>> (istream is, EventoHistorico& EH){
         return is; // not OK !   ^^--- pass by value
    }
    

    You should not return a refernce if is is a local variable (you make a copy of the istream when it is passed as parameter). When it is a reference, then you can also return a reference to it:

    istream& operator>> (istream& is, EventoHistorico& EH)
        return is; // OK !       ^^--- pass by reference
    }