elixirecto

Conditional Validation in Ecto for OR - 1 of 2 fields is required


How can I do conditional validation for OR logic, where we check to see if 1 of the 2 values is present or both values are present.

So, for example, if I want to check to make sure that the email or the mobile fields are filled... I want to be able to pass a list into fields of validate_required_inclusion to validate that at least 1 of the fields in the list is not null.

def changeset(struct, params \\ %{}) do
    struct
    |> cast(params, [:email, :first_name, :last_name, :password_hash, :role, :birthdate, :address1, :address2, :city, :state, :zip, :status, :mobile, :card, :sms_code, :status])
    |> validate_required_inclusion([:email , :mobile])
end


def validate_required_inclusion(changeset, fields,  options \\ []) do

end

How can I do this conditional OR validation?


Solution

  • Here's a simple way. You can customize it to support better error messages:

    def validate_required_inclusion(changeset, fields) do
      if Enum.any?(fields, &present?(changeset, &1)) do
        changeset
      else
        # Add the error to the first field only since Ecto requires a field name for each error.
        add_error(changeset, hd(fields), "One of these fields must be present: #{inspect fields}")
      end
    end
    
    def present?(changeset, field) do
      value = get_field(changeset, field)
      value && value != ""
    end
    

    Test with a Post model and |> validate_required_inclusion([:title , :content]):

    iex(1)> Post.changeset(%Post{}, %{})
    #Ecto.Changeset<action: nil, changes: %{},
     errors: [title: {"One of these fields must be present: [:title, :content]",
       []}], data: #MyApp.Post<>, valid?: false>
    iex(2)> Post.changeset(%Post{}, %{title: ""})
    #Ecto.Changeset<action: nil, changes: %{},
     errors: [title: {"One of these fields must be present: [:title, :content]",
       []}], data: #MyApp.Post<>, valid?: false>
    iex(3)> Post.changeset(%Post{}, %{title: "foo"})
    #Ecto.Changeset<action: nil, changes: %{title: "foo"}, errors: [],
     data: #MyApp.Post<>, valid?: true>
    iex(4)> Post.changeset(%Post{}, %{content: ""})
    #Ecto.Changeset<action: nil, changes: %{},
     errors: [title: {"One of these fields must be present: [:title, :content]",
       []}], data: #MyApp.Post<>, valid?: false>
    iex(5)> Post.changeset(%Post{}, %{content: "foo"})
    #Ecto.Changeset<action: nil, changes: %{content: "foo"}, errors: [],
     data: #MyApp.Post<>, valid?: true>