androidruntime-errorandroid-logcatnetworkonmainthread

Android App can't get Data from Web


Why I get this Error and my app stop. I try to change all domains and all domains are available. The Mobile Phone have Internet connection and in the Manifest I don't forget the Internet premission. I don't know what I forget. I think it's because I click on the Button and I think isNetworkAvailable() boolean didn't support the View v.

Line:34 : socket.connect(new InetSocketAddress("example.com", 80), 2000);

Line:97 : if(isNetworkAvailable()) {

public void setnewuser(View v){
      EditText benutzername = (EditText) findViewById(R.id.benutzername);
      TextView error = (TextView) findViewById(R.id.error);


    if (benutzername.getText().toString().trim() != "") {

            String newusid = null;
            URL url = null;
            if(isNetworkAvailable()) {
                try {
                    url = new URL(gamehost + "/newuser.php");
                    String readLine = null;
                    String sResult = null;
                    BufferedReader buffReader = new BufferedReader(new InputStreamReader(url.openStream()));
                    while ((readLine = buffReader.readLine()) != null) {
                        if (sResult == null) {
                            sResult = readLine;
                        } else {
                            sResult = sResult + readLine;
                        }
                    }
                    newusid = sResult;
                } catch (MalformedURLException me) {
                    me.printStackTrace();
                } catch (IOException ioe) {
                    ioe.printStackTrace();
                }
            }
            String userid = newusid;
            if(userid != "") {
                editor.putString("username", benutzername.getText().toString().trim());
                editor.commit();
                editor.putString("userid", userid);
                editor.commit();
                startActivity(new Intent(Setname.this, Game.class));
                finish();
            }else{
                error.setText(R.string.needinternetforregist);
            }



    } else {
        error.setText(R.string.etwaseingeben);
    }

The isNetworkAvailabe() boolean:

public boolean isNetworkAvailable() {
    try (Socket socket = new Socket()) {
        socket.connect(new InetSocketAddress("example.com", 80), 2000);
        return true;
    } catch (IOException e) {
        // Either we have a timeout or unreachable host or failed DNS lookup
        System.out.println(e);
        return false;
    }
}

Logcat:

                                                                              Process: de.gamer.myapp, PID: 13895
                                                                                 java.lang.IllegalStateException: Could not execute method for android:onClick
                                                                                     at android.support.v7.app.AppCompatViewInflater$DeclaredOnClickListener.onClick(AppCompatViewInflater.java:293)
                                                                                     at android.view.View.performClick(View.java:6213)
                                                                                     at android.widget.TextView.performClick(TextView.java:11074)
                                                                                     at android.view.View$PerformClick.run(View.java:23645)
                                                                                     at android.os.Handler.handleCallback(Handler.java:751)
                                                                                     at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                                     at android.os.Looper.loop(Looper.java:154)
                                                                                     at android.app.ActivityThread.main(ActivityThread.java:6692)
                                                                                     at java.lang.reflect.Method.invoke(Native Method)
                                                                                     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
                                                                                     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)
                                                                                  Caused by: java.lang.reflect.InvocationTargetException
                                                                                     at java.lang.reflect.Method.invoke(Native Method)
                                                                                     at android.support.v7.app.AppCompatViewInflater$DeclaredOnClickListener.onClick(AppCompatViewInflater.java:288)
                                                                                     at android.view.View.performClick(View.java:6213) 
                                                                                     at android.widget.TextView.performClick(TextView.java:11074) 
                                                                                     at android.view.View$PerformClick.run(View.java:23645) 
                                                                                     at android.os.Handler.handleCallback(Handler.java:751) 
                                                                                     at android.os.Handler.dispatchMessage(Handler.java:95) 
                                                                                     at android.os.Looper.loop(Looper.java:154) 
                                                                                     at android.app.ActivityThread.main(ActivityThread.java:6692) 
                                                                                     at java.lang.reflect.Method.invoke(Native Method) 
                                                                                     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468) 
                                                                                     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358) 
                                                                                  Caused by: android.os.NetworkOnMainThreadException
                                                                                     at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1303)
                                                                                     at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:86)
                                                                                     at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:74)
                                                                                     at java.net.InetAddress.getByName(InetAddress.java:708)
                                                                                     at java.net.InetSocketAddress.<init>(InetSocketAddress.java:232)
                                                                                     at de.gamer.Setname.isNetworkAvailable(Setname.java:34)
                                                                                     at de.gamer.Setname.setnewuser(Setname.java:97)

Solution

  • Caused by: android.os.NetworkOnMainThreadException

    That means you are trying to connect to the internet in the main thread.

    You have to use an AsyncTask