I have the following sql trigger that is inserting data into a table named PS_AUDIT_PSROLEUSR
, based on a Delete action that occurred on a related table.
When the table update is triggered by an online user in the application (a role row is removed) then the entire OPRID is inserted correctly into PS_AUDIT_PSROLEUSR
, however when the triggers runs via a batch program I have written, it is only getting the first letter of the AUDIT_OPRID
. I have confirmed this by running the program under another OPRID
, and it still only inserts the first character into the column. Forgive me that I am not very familiar with SQL triggers.
ALTER TRIGGER [dbo].[PSROLEUSER_TR]
ON [dbo].[PSROLEUSER]
FOR INSERT, UPDATE, DELETE
AS
SET NOCOUNT ON
DECLARE @XTYPE CHAR(1), @OPRID CHAR(30)
SET @OPRID = NULL
SELECT @OPRID = CASE(CHARINDEX(',', CAST(context_info AS CHAR(128))))
WHEN 0 THEN 'Native SQL'
ELSE SUBSTRING(CAST(context_info AS CHAR(128)), 1, (CHARINDEX(',', CAST(context_info AS CHAR(128)))-1))
END
FROM sys.sysprocesses
WHERE spid = @@spid
-- Determine Transaction Type
IF EXISTS (SELECT * FROM DELETED)
BEGIN
SET @XTYPE = 'D'
END
IF EXISTS (SELECT * FROM INSERTED)
BEGIN
IF (@XTYPE = 'D')
BEGIN
SET @XTYPE = 'U'
END
ELSE
BEGIN
SET @XTYPE = 'I'
END
END
-- Transaction is a Delete
IF (@XTYPE = 'D')
BEGIN
INSERT INTO PS_AUDIT_PSROLEUSR (AUDIT_OPRID, AUDIT_STAMP, AUDIT_ACTN, ROLEUSER, ROLENAME, DYNAMIC_SW)
SELECT
@OPRID,
DATEADD(SECOND, ROW_NUMBER() OVER (ORDER BY @OPRID), GETDATE()),
'D', ROLEUSER, ROLENAME, DYNAMIC_SW
FROM
deleted
END
-- Transaction is a Insert
IF (@XTYPE = 'I')
BEGIN
INSERT INTO PS_AUDIT_PSROLEUSR (AUDIT_OPRID, AUDIT_STAMP, AUDIT_ACTN, ROLEUSER, ROLENAME, DYNAMIC_SW)
SELECT
@OPRID, GETDATE(),
'A', ROLEUSER, ROLENAME, DYNAMIC_SW
FROM
inserted
END
-- Transaction is a Update
IF (@XTYPE = 'U')
BEGIN
-- Before Update
INSERT INTO PS_AUDIT_PSROLEUSR (AUDIT_OPRID, AUDIT_STAMP, AUDIT_ACTN, ROLEUSER, ROLENAME, DYNAMIC_SW)
SELECT
@OPRID, GETDATE(), 'K',
ROLEUSER, ROLENAME, DYNAMIC_SW
FROM
deleted
-- After Update
INSERT INTO PS_AUDIT_PSROLEUSR (AUDIT_OPRID, AUDIT_STAMP, AUDIT_ACTN, ROLEUSER, ROLENAME, DYNAMIC_SW)
SELECT
@OPRID, GETDATE(), 'N',
ROLEUSER, ROLENAME, DYNAMIC_SW
FROM
inserted
END
EXAMPLE OF ROW INSERTED IN PS_AUDIT_PSROLEUSR
AUDIT_OPRID AUDIT_STAMP AUDIT_ACTN ROLEUSER ROLENAME DYNAMIC_SW
K 2019-04-25 08:33:08.340 D LTESTUSER EUSER N
K 2019-04-25 08:33:09.340 D LTESTUSER EPRO N
I can't seem to access the 'DELETE' table in the SELECT * FROM DELETED
so I'm not sure if this is just dynamically generated at run time only.
Side note - whats kind of odd is that is I query PS_AUDIT_PSROLEUSR as follows for the value 'K' I get 0 rows returned. I've checked that there are no trailing spaces behind the letter.
SELECT *
FROM PS_AUDIT_PSROLEUSR
WHERE AUDIT_OPRID = 'K'
I only get data for 'K' if I use the LIKE
operator
-- Results in 0 rows
EDIT: If I run the following code I am getting 12 character length for my row inserted with 'K' so something is adding extra trailing spaces...
SELECT LEN(AUDIT_OPRID),*
FROM PS_AUDIT_PSROLEUSR
WHERE AUDIT_OPRID like 'K%'
I've also tried adding this simple IF statement to the trigger, however it does not seem to work either: I thought doing the conversion from binary (context_info) to varchar would allow the logic to filter out the value 'K'.
IF (CONVERT(VARCHAR(256),@OPRID)) <> 'K'
BEGIN
This is not a necessarily a problem with the trigger but the character encoding of the CONTEXT_INFO
binary value when set by the batch application. You will get these symptoms when the CONTEXT_INFO
value is actually a Unicode string and the binary value is subsequently cast as CHAR
in T-SQL.
Consider this example:
DECLARE @ContextInfo varbinary(128) = CAST(N'ABC,DEF,GHI' AS varbinary(128));
SET CONTEXT_INFO @ContextInfo;
GO
DECLARE @OPRID CHAR(30) = NULL;
SELECT CAST(context_info AS CHAR(30)) AS CharValue, CAST(context_info AS NCHAR(30)) AS NCharValue
FROM sys.sysprocesses
WHERE spid = @@spid;
GO
Results:
+-----------+-------------+
| CharValue | NCharValue |
+-----------+-------------+
| A | ABC,DEF,GHI |
+-----------+-------------+
To address the issue, you could either change the application code to set CONTEXT_INFO
to an ANSI string or change the T-SQL CASE expression to CAST
the value as NCHAR
. Below is T-SQL example that does this and also uses the sys.dm_exec_sessions
DMV instead of sys.processes
, which has been deprecated for 15 years.
SELECT @OPRID = CASE(CHARINDEX(',', CAST(context_info AS NCHAR(64))))
WHEN 0 THEN N'Native SQL'
ELSE SUBSTRING(CAST(context_info AS NCHAR(64)), 1, (CHARINDEX(',', CAST(context_info AS NCHAR(64)))-1))
END
FROM sys.dm_exec_sessions
WHERE session_id = @@spid;