laraveljobs

How do I run a limited number of background processes from laravel jobs?


I want to run ffmpeg processes from laravel jobs, but not too many all at once. I just can't seem to get it right. No matter what I set for $process_limit - It only runs one at a time and there are long delays in-between. Perhaps I'm using public $timeout wrong. Perhaps retryUntil(). I don't know.

<?php

namespace FuquIo\LaravelFfmpeg;

use Cocur\BackgroundProcess\BackgroundProcess;
use Illuminate\Bus\Queueable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Redis;

class RenderMpeg4ToWebmJob implements ShouldQueue{
use Dispatchable, InteractsWithQueue, Queueable;

public $timeout = 3600;

/**
 * @var string
 */
private $input_file;
/**
 * @var array
 */
private $map;

/**
 * Create a new job instance.
 *
 * @param array  $map
 * @param string $input_file
 */
public function __construct(array $map, string $input_file){
    //
    $this->map        = $map;
    $this->input_file = $input_file;
}

/**
 * Execute the job.
 *
 * @return void
 * @throws \Exception
 */
public function handle(){

    $almost_timeout = $this->timeout - 100;
    $map            = $this->map;
    $input_file     = $this->input_file;

    $cmds = '(' . implode('; ', config('fuqu-ffmpeg.command')) . ')';
    $cmds = str_replace(array_keys($map), array_values($map), $cmds);

    Log::debug($cmds);

    $process_limit = config(ServiceProvider::SHORT_NAME .'.process_limit');
    Redis::funnel('ffmpeg')->limit($process_limit)->then(
        function () use ($cmds, $input_file, $almost_timeout){

            $process = new BackgroundProcess($cmds);
            $process->run();

            if(!$process->isRunning()){
                throw new \Exception('Unable to execute file processing command on ' . $input_file);
            }

            /**
             * This doesn't prevent an additional
             * background process from spawning
             * but it does give a head start
             */
            $slept = 0;
            do{
                sleep(10);
                $slept += 10;
            }while($process->isRunning() and ($slept < $almost_timeout));

        }, function (){
        // Could not obtain lock...

        return $this->release(100);
    });


}

/**
 * Rather than doing x tries,
 * just keep trying until.
 *
 * @return \DateTime
 */
public function retryUntil(){
    return now()->addDays(1);
}

}


Solution

  • It turned out the code in the question actually worked. My problem as within the bg process. It was having trouble with files that ended in a number. I'll leave the code up I guess... could be useful for someone.