I have four tables:
Activity:
ActivityID(PK) ActivityName CustomerID(FK) UserId(FK)
1 Lead Gen 1st 50 U1
2 Lead Gen 2nd 60 U2
Customer:
CustomerID(PK) CustomerNumber CustomerName
50 C0150 cust50 ltd
60 C0160 cust60 ltd
User:
UserID(PK) UserName Email
U1 Mr. X X@cat.com
U2 Mr. Y Y@cat.com
UserActivity:
UserActivityID(PK) UserID(FK) ActivityID(FK)
888 U1 1
889 U2 2
I want to send an email (i.e. Email:X@cat.com) to the users related to the activity (i.e. ActivityId:1) if any insert happens in Activity
Table (SQL Server 2008-R2).
The email body should contain the ActivityId
, ActivityName
, CustomerNumber
and CustomerName
.
The trigger has to do the above mentioned and the result should be like this in the email:
ActivityID:1, ActivityName:Lead Gen 1st created for CustomerNumber: C0150 & CustomerName: cust50 ltd
Here is my code:
CREATE TRIGGER [dbo].[Activity_Insert_Mail_Notification]
ON [dbo].[Activity]
AFTER INSERT
AS
BEGIN
DECLARE @ActivityID varchar(2000)
DECLARE @ActivityName varchar (2000)
Select @ActivityID=inserted.ActivityID,@ActivityName=inserted.ActivityName
From inserted
DECLARE @CustomerNo varchar(2000)
DECLARE @CustomerName varchar(2000)
Select @CustomerNo = B.[CustomerNumber]
,@CustomerName= B.[CustomerName]
from [dbo].[Activity] A
inner join [dbo].[Customer] B
on A.[CustomerID]=B.[CustomerID]
DECLARE @email VARCHAR(2000)
SELECT @email = RTRIM(U.[Email]) + ';'
FROM [dbo].[Activity] A
left join [dbo].[UserActivity] UA
inner join [dbo].[User] U
on UA.[UserID]=U.[UserID]
on A.[ActivityID]=UA.[ActivityID]
WHERE U.[Email]<> ''
DECLARE @content varchar (2000)
= 'ActivityID:' + @ActivityId + ' '
+ ',ActivityName:' + @ActivityName + ' '
+ 'has been created for' + 'CustomerNumber: ' + @CustomerNo
+ ' ' + '&CustomerName: ' + @CustomerName
EXEC msdb.dbo.sp_send_dbmail
@profile_name = 'LEADNOTIFY'
,@recipients = @email
,@subject = 'New Lead Found'
,@body = @content
,@importance ='HIGH'
END
The problem is in my code that I can't fetch the customer data and email from the respective tables properly.
I have written some code below which will loop through all the effected rows and send an email for each.
However before you read that, I would highly recommend (as @HABO commented) on using a different approach. Triggers are fine for some tasks, but 2 key things you want to keep in mind when using triggers:
Sending emails is a terrible thing to do inside a trigger because its not uncommon to be forced to wait for an SMTP server to respond. If you wish to trigger emails, a better way is to use the trigger to insert the email data into a queuing table and then have a service elsewhere which de-queues these emails and sends them.
All that aside the following code shows one way to handle the Inserted
pseudo-table when you want to perform RBAR operations. Because in SQL Server the Inserted
pseudo-table (and the Deleted
pseudo-table) will contain the number of rows effected by the operation i.e. 0-N. Also I've hopefully joined your tables to correctly obtain the required information.
CREATE TRIGGER [dbo].[Activity_Insert_Mail_Notification]
ON [dbo].[Activity]
AFTER INSERT
AS
BEGIN
SET NOCOUNT ON;
DECLARE @ActivityID VARCHAR(2000), @ActivityName VARCHAR(2000), @CustomerNo VARCHAR(2000), @CustomerName VARCHAR(2000), @Email VARCHAR(2000), @Content VARCHAR(2000);
-- Get all the relevant information into a temp table
SELECT ActivityID, ActivityName, C.CustomerNumber, C.CustomerName, RTRIM(U.[Email]) + ';' Email, CONVERT(BIT, 0) Handled
INTO #ActivityTriggerTemp
FROM Inserted I
INNER JOIN Customer C on C.CustomerID = I.CustomerID
INNER JOIN UserActivity UA on UA.ActivityID = I.ActivityID
INNER JOIN [USER] U on U.UserID = UA.UserID;
-- Loop through the temp table sending an email for each row, then setting the row as 'handled' to avoid sending it again.
WHILE EXISTS (SELECT 1 FROM #ActivityTriggerTemp WHERE Handled = 0) BEGIN
SELECT TOP 1 @ActivityID = ActivityID, @ActivityName = ActivityName, @CustomerNumber = CustomerNumber, @CustomerName = CustomerName, @Email = Email
FROM #ActivityTriggerTemp
WHERE Handled = 0;
-- Build the body of the email
set @Content = 'ActivityID:' + @ActivityId + ' '
+ ',ActivityName:' + @ActivityName + ' '
+ 'has been created for' + 'CustomerNumber: ' + @CustomerNo
+ ' ' + '&CustomerName: ' + @CustomerName;
-- Send the email
EXEC msdb.dbo.sp_send_dbmail
@profile_name = 'LEADNOTIFY'
, @recipients = @Email
, @subject = 'New Lead Found'
, @body = @Content
, @importance ='HIGH';
UPDATE #ActivityTriggerTemp SET
Handled = 1
WHERE ActivityID = @ActivityID AND ActivityName = @ActivityName AND CustomerNumber = @CustomerNumber AND CustomerName = @CustomerName AND Email = @Email;
END;
END