In my app I have a queue with items in a database that should be sent to a server. Since I want this queue to be monitored continuously and since this task includes network communication I have made a class that implements Runnable that I call my QueueWorkerThread. But for some reason I still get the "android.os.NetworkOnMainThreadException" and I don't understand why? I've tried searching for similar issues here on SO, but anything even close is using AsyncTask and since that class apparently will become depricated in API level 30 I don't want to use it (I want this app to work for a long time). Is my Runnable somehow running something back on the main thread? Is that even possible?
Here's the code for my QueueWorker Thread:
public class QueueWorkerThread implements Runnable{
private final static String TAG = "QueueWorkerThread";
private AtomicBoolean alive = new AtomicBoolean(true);
private Context mContext;
private FragmentRefreshInterface mFragmentRefreshInterface;
private NetworkStatusInterface mNetworkStatusInterface;
public QueueWorkerThread(Context context, FragmentRefreshInterface fragmentRefreshInterface, NetworkStatusInterface networkStatusInterface) {
mContext = context;
mFragmentRefreshInterface = fragmentRefreshInterface;
mNetworkStatusInterface = networkStatusInterface;
Log.d(TAG," Thread Started");
}
public void quit(){
alive.set(false);
}
public void makeReady(){
alive.set(true);
}
@Override
public void run() {
SQLiteDatabase database = SQLiteHelper.getSingleton(mContext).getWritableDatabase();
ServerCommunicationHelper communicationHelper = new ServerCommunicationHelper(mFragmentRefreshInterface,mNetworkStatusInterface);
while (alive.get()){
TracerQueueVO tracerQueueVO = SQLiteHelper.getSingleton(mContext).getNextQueueVOFromDatabase(database);
if(tracerQueueVO.getTracerId()!=null){
int result = communicationHelper.uploadQueueVO(tracerQueueVO, mContext);
if(result == ServerCommunicationHelper.UPLOAD_OK){
SQLiteHelper.getSingleton(mContext).removeQueueVOFromDatabase(database,tracerQueueVO);
}else{
SQLiteHelper.getSingleton(mContext).updateQueueVOInDatabase(database,tracerQueueVO);
}
}
try {
sleep(5000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
}
This is the code in MainActivity where I start my Thread:
private void startQueueWorkerThread(){
if (mQueueWorkerThread == null){
mQueueWorkerThread = new QueueWorkerThread(mContext,this, this);
new Thread(mQueueWorkerThread).start();
} else {
mQueueWorkerThread.makeReady();
mQueueWorkerThread.run();
}
}
Here's the code in my ServerCommunicationHelper where the error occurs:
public int uploadQueueVO(ItemQueueVO queueVO, Context context){
int result = 0;
try {
String json = queueVO.getData();
byte[] base64 = Base64.encode(json.getBytes(),0);
final OkHttpClient CLIENT = new OkHttpClient();
Request request = new Request.Builder()
.url(url)
.post(RequestBody.create(MediaType.parse("text/plain; charset=utf8"),base64))
.build();
Response response = CLIENT.newCall(request).execute();
if (response.isSuccessful()){
result = UPLOAD_OK;
}else{
result = UPLOAD_FAILED;
}
} catch (Exception e) {
e.printStackTrace();
result = UPLOAD_FAILED;
}
return result;
And this is the stack trace:
W/System.err: android.os.NetworkOnMainThreadException
at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1565)
W/System.err: at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:389)
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:230)
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:212)
W/System.err: at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:436)
at java.net.Socket.connect(Socket.java:621)
at okhttp3.internal.platform.AndroidPlatform.connectSocket(AndroidPlatform.java:73)
W/System.err: at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.java:245)
at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:165)
W/System.err: at okhttp3.internal.connection.StreamAllocation.findConnection(StreamAllocation.java:257)
at okhttp3.internal.connection.StreamAllocation.findHealthyConnection(StreamAllocation.java:135)
W/System.err: at okhttp3.internal.connection.StreamAllocation.newStream(StreamAllocation.java:114)
at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:42)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
W/System.err: at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93)
W/System.err: at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
W/System.err: at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:126)
W/System.err: at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:200)
W/System.err: at okhttp3.RealCall.execute(RealCall.java:77)
at com.xxxxxx.xx.network.ServerCommunicationHelper.uploadQueueVO(ServerCommunicationHelper.java:136)
W/System.err: at com.xxxxxx.xx.queue.QueueWorkerThread.run(QueueWorkerThread.java:49)
at com.xxxxxx.xx.MainActivity.startQueueWorkerThread(MainActivity.java:1193)
at com.xxxxxx.xx.MainActivity.onResume(MainActivity.java:373)
at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1454)
at android.app.Activity.performResume(Activity.java:8105)
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:4529)
W/System.err: at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:4572)
at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:52)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2220)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
W/System.err: at android.app.ActivityThread.main(ActivityThread.java:8016)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1076)
In the else part, you are calling run methods directly which will execute the network call on mail thread, hence the exception
// this method is being called in onResume so
// second time, mQueueWorkerThread.run will be executed on main thread
private void startQueueWorkerThread(){
if (mQueueWorkerThread == null){
mQueueWorkerThread = new QueueWorkerThread(mContext,this, this);
new Thread(mQueueWorkerThread).start();
} else {
mQueueWorkerThread.makeReady();
mQueueWorkerThread.run(); // it will cause the exception
// new Thread(mQueueWorkerThread).start(); should use this
}
}