c++boostc++17factorialgamma-function

calculating the Gamma function for negative real values (C++, Boost)


The following infinite serious require the calculation of factorial for non-integer, negative, real numbers: Infinite serious:

(it is a way to calculate the circumference of an ellipse, a and b are the semi-major and semi minor axis and h is defined as:
h = (a-b)^2/(a+b)^2)

The factorial function can be extended to negative values via the Gamma function which is defined for all the real numbers that are not negative integers.

While coding the serious I tried boost::math::factorial and boost::math::tgamma which gives results only down to -1 (not included) -1.5 for example give an error.

    #include <iostream>
    #include <boost/math/special_functions/factorials.hpp>

    int main()
    {
        double x;
        double f;
        double tg;

        x = -0.5;
        f = boost::math::factorial<double>(x);
        tg = boost::math::tgamma<double>(x);
        cout << "factorial of " << x << " = " << f << endl;
        cout << "tgamma of " << x << " = " << tg << endl << endl;

        x = -1.5;
        f = boost::math::factorial<double>(x);
        tg = boost::math::tgamma<double>(x);
        cout << "factorial of " << x << " = " << f << endl;
        cout << "tgamma of " << x << " = " << tg << endl << endl;
    
        return 0;
    }

the output:

factorial of -0.5 = 1
tgamma of -0.5 = -3.54491
terminate called after throwing an instance of 'boost::exception_detail::clone_implboost::exception_detail::error_info_injector<std::domain_error >' what(): Error in function boost::math::tgamma(long double): Evaluation of tgamma at a negative integer 0. Aborted (core dumped)

boost factorial: boost factorial
boost tgamma: boost tgamma

My questions:

  1. Is there an alternative to boost that can calculate the gamma function for its negative domain?
  2. I could not find in the boost documentation linked above mention of the implemented domain for factorials and tgamma functions. In fact I might simply be using them wrong. What is the way to ascertain what is indeed the domain/correct usage?

Thanks.


Solution

  • I understand what's going wrong. The boost::math::factorial function takes an unsigned integer by definition:

    template <class T>
    inline T factorial(unsigned i)
    {
       return factorial<T>(i, policies::policy<>());
    }
    

    This means that if you call it with a double, it will get implicitly converted to unsigned. That's not what you want. Also, factorial ends up using tgamma internally, so you get this:

    #include <boost/math/special_functions/factorials.hpp>
    #include <iostream>
    
    void foo(long double x) {
        using namespace boost::math;
        try {
            auto f = factorial<long double>(x);
            std::cout << "factorial of " << static_cast<unsigned>(x) << " = " << f << "\n";
        } catch(std::exception const& e) {
            std::cout << "error at " << static_cast<unsigned>(x) << ": " << std::quoted(e.what()) << "\n";
        }
    }
    
    int main() {
        std::cout << std::unitbuf;
        foo(-2);
    }
    

    Will end up doing this:

    #0  boost::math::tgamma<long double, boost::math::policies::policy<boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy> > (a=4294967295, z=...)
        at /home/sehe/custom/boost_1_73_0/boost/math/special_functions/gamma.hpp:1994
    No locals.
    #1  0x0000555555558eb3 in boost::math::factorial<long double, boost::math::policies::policy<boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy> > (i=4294967294, pol=...)
        at /home/sehe/custom/boost_1_73_0/boost/math/special_functions/factorials.hpp:44
            result = -0.667762310955655363645
    #2  0x0000555555558674 in boost::math::factorial<long double> (i=4294967294)
        at /home/sehe/custom/boost_1_73_0/boost/math/special_functions/factorials.hpp:53
    No locals.
    #3  0x0000555555557792 in foo (x=-2) at /home/sehe/Projects/stackoverflow/test.cpp:7
            f = <invalid float value>
    #4  0x000055555555791f in main () at /home/sehe/Projects/stackoverflow/test.cpp:16
    No locals.
    

    So it's attempting to give you boost::math::factorial<long double> (i=4294967294)

    Fix

    Don't use factorials for other than non-negative integers.

    Live On Compiler Explorer

    #include <boost/math/special_functions/factorials.hpp>
    #include <iostream>
    
    void foo(long double x) {
        using namespace boost::math;
        try {
            auto tg = tgamma<long double>(x);
            std::cout << "tgamma    of " << x << " = " << tg << "\n" << std::endl;
        } catch(std::exception const& e) {
            std::cout << "error at " << x << ": " << std::quoted(e.what()) << std::endl;
        }
    }
    
    int main() {
        for (auto x : { 1., 2., 3., 4., 5., -.2, -2., -.5, -1.5 })
            foo(x);
    }
    

    Prints:

    tgamma    of 1 = 1
    
    tgamma    of 2 = 1
    
    tgamma    of 3 = 2
    
    tgamma    of 4 = 6
    
    tgamma    of 5 = 24
    
    tgamma    of -0.2 = -5.82115
    
    error at -2: "Error in function boost::math::tgamma<long double>(long double): Evaluation of tgamma at a negative integer -2."
    tgamma    of -0.5 = -3.54491
    
    tgamma    of -1.5 = 2.36327
    

    It understandably overflows at -2, but that's correct.