c++segmentation-faultinfix-operator

How to resolve the segmentation fault in this code?


I am trying to make an infix calculator for which I am currently trying to convert numbers entered in a character array to double.

here's my code:


#include <iostream>
#include<cmath>
using namespace std;

int main()
{
    char exp[500];
    const int SIZE = 100;
    char temp[SIZE];
    char op;

    int strLen = 0, k, l, num = 0, fnum = 0;
    double number = 0;

    cin.getline(exp, 500,'\n');

    int i = 0, j = 0, fpoint=0;

    cout << exp;

    for (i = 0, j = 0; exp[j] != 0; i++)
    {
        if (i % 2 == 0)
        {
            for (int m = 0; exp[m] != ','; m++) //stopped working
                temp[m] = exp[m];
            
            cout << temp;
            
            for (k = 0; k < SIZE && temp[k] != 0; k++)
            {
                strLen = k;
                if (temp[k] == '.')
                    fpoint = k + 1;
            }

            cout << fpoint<<endl;


            cout << "strLen" << strLen;

            for (k = 0; k <= fpoint; k++)
            {
                num = num + ((temp[fpoint - k] - '0') * pow(10, k));
            }

            for (k = fpoint + 1, l = 0; k <= strLen; k++, l++)
            {
                fnum = fnum + ((temp[strLen - l] - '0') * pow(10, l));
            }

            number = num + (fnum / pow(10, strLen - fpoint + 1));

            cout << number;

            j = j + strLen + 1;

        }
        else
        {
            char op = temp[j];
            cout << op;
        }
    }
    system("pause");
    return 0;
}


sample input

2.5*3

It stops working and gives segmentation fault as an error on the marked position.


Solution

  • This line for (int m = 0; exp[m] != ','; m++) //stopped working will always fail if there are no , characters since exp[m] != ',' will always be equal to true and so will reach beyond the end of the array of exp which triggers the "segmentation fault".