I'm trying to convert my local /dev/video0 cam to BGR24 format. It works if I resize the image (although not 100% of the time, more like 85% of the time), but I'd like to keep the same size as input video.
I initialize BGR image like so including the sws context:
AVPixelFormat outputPixFormat = AV_PIX_FMT_BGR24;
AVFrame* pFrameBGR = av_frame_alloc();
pFrameBGR->width = decoder->video_codec_context->width;
pFrameBGR->height = decoder->video_codec_context->height;
pFrameBGR->format = outputPixFormat;
int alloRet = av_image_alloc(pFrameBGR->data, pFrameBGR->linesize, decoder->video_codec_context->width, decoder->video_codec_context->height, outputPixFormat, 1);
if (alloRet < 0) {
logging("failed to allocate image");
return -1;
}
struct SwsContext *sws_ctx = NULL;
sws_ctx = sws_getContext(decoder->video_codec_context->width,
decoder->video_codec_context->height,
decoder->video_codec_context->pix_fmt,
decoder->video_codec_context->width,
decoder->video_codec_context->height,
outputPixFormat,
SWS_DIRECT_BGR,
0,
0,
0
);
This is the portion of my decoding loop:
int response = avcodec_send_packet(pCodecContext, pPacket);
if (response < 0) {
logging("Error while sending a packet to decoder: %s", av_err2str(response));
return response;
}
while (response >= 0) {
response = avcodec_receive_frame(pCodecContext, pFrame);
if (response == AVERROR(EAGAIN) || response == AVERROR_EOF) {
break;
} else if (response < 0) {
logging("Error while receiving a frame from the decoder: %s", av_err2str(response));
return response;
}
if (response >= 0) {
sws_scale(sws_ctx, (uint8_t const * const *)pFrame->data, pFrame->linesize, 0, pCodecContext->height, pFrameBGR->data, pFrameBGR->linesize);
THe question is how to copy the plane of AVFrame into a buffer
:
size_t rgb_size = av_image_get_buffer_size(AV_PIX_FMT_BGR24, bgrFrame->width, bgrFrame->height, 1);
uint8_t *dst_data;
dst_data = (uint8_t *)(av_malloc(rgb_size));
av_image_copy_to_buffer(dst_data, rgb_size, (const uint8_t* const *)bgrFrame->data, bgrFrame->linesize, AV_PIX_FMT_BGR24, bgrFrame->width, bgrFrame->height, 1);
If I try to save to file the BGR image is correctly copied:
char filebuf[256];
snprintf(filebuf, sizeof filebuf, "%s%d%s", "out_", pPacket->dts, ".rgb");
std::FILE *output=fopen(filebuf,"wb+");
fwrite(bgrFrame->data[0],(pFrame->width)*(pFrame->height)*3,1,output);
std::fclose(output);
So it looks like my copy to buffer function is faulty, but I can figure out what's wrong with it:
uint8_t *dst_data;
dst_data = (uint8_t *)(av_malloc(rgb_size));
av_image_copy_to_buffer(dst_data, rgb_size, (const uint8_t* const *)bgrFrame->data, bgrFrame->linesize, AV_PIX_FMT_BGR24, bgrFrame->width, bgrFrame->height, 1);
The code above is completely correct. The problem was in the subsequent code serializing the dst_data
buffer where I was ignoring/forgetting the length of the buffer. Thanks to @SuRGeoNix for leading me in the right direction.