githubpull-requestgithub-codereviews

Github PR: Approval needed after approval has already been given?


I approved a PR, and see:

"approved these changes now"

but then right below that I still see:

"At least 1 approving review is required by reviewers with write access."

I went to the branch, and I am a contributor, so I should have write access, right?

Not sure what's up with this PR.

I've approved the PR multiple times now. I've clicked the "Viewed" checkbox on all the files, but still it will not allow the Review required block to turn from the red X to the green circle white checkmark.


Solution

  • Per the comment above, when I came back to this thread:

    https://github.com/orgs/community/discussions/58535?sort=top#discussioncomment-6233887

    I was able to validate what @dgokcin verified. I closed the PR, reopened, resubmitted my same review, and this time it went through.

    Might just mark this question as a dupe. My apologies for not finding the thread above sooner.