c++dynamic-programming

how do i fix this dynamic programming code?


Polycarpus has a ribbon, its length is n. He wants to cut the ribbon in a way that fulfils the following two conditions:
After the cutting each ribbon piece should have length a, b or c.
After the cutting the number of ribbon pieces should be maximum.
Help Polycarpus and find the number of ribbon pieces after the required cutting.
The first line contains four space-separated integers n, a, b and c (1 ≤ n, a, b, c ≤ 4000) — the length of the original ribbon and the acceptable lengths of the ribbon pieces after the cutting, correspondingly. The numbers a, b and c can coincide.
Print a single number — the maximum possible number of ribbon pieces. It is guaranteed that at least one correct ribbon cutting exists.

kinda simple code, but can't deal with 45 test. can't come up with test that disproves this code. not TL, wrong answer

#include <iostream>
#include <cmath>
#include <algorithm>
using namespace std;
int main()
{
     int n, a, b, c;
     cin >> n;
     cin >> a >> b >> c;
     if (a < b) swap(a, b);
     if (a < c) swap(a, c);
     if (b < c) swap(b, c);
     for (int i = 0; i <= n / a; i++)
     {
         for (int j = 0; j <= n / b; j++)
         {
             for (int k = 0; k <= n / c; k++)
             {
                 if (n - (i * a + j * b + k * c) == 0)
                 {
                     int answer=i+j+k;
                     cout << answer;
                     return 0;
                 }
             }
         }
    }
    cout << 0;
    return 0;
}

Solution

  • Your solution is wrong and I will give you an example:

    n = 101, a = 50, b = 49, c = 3
    

    Your solution will break with i = 0, j = 2, k = 1.

    But the best solution is i = 1, j = 0, k = 17.

    And the right solution should check all the possible ways of cutting:

    #include <iostream>
    #include <cmath>
    #include <algorithm>
    using namespace std;
    int main()
    {
        int n, a, b, c;
        cin >> n;
        cin >> a >> b >> c;
        if (a < b) swap(a, b);
        if (a < c) swap(a, c);
        if (b < c) swap(b, c);
        int answer = 0;
        for (int i = 0; i <= n / a; i++)
        {
            for (int j = 0; j <= n / b; j++)
            {
                int rem = n - a*i - j*b;
                if (rem % c == 0) 
                {
                    answer = max(answer, i+j+rem/c);
                }
            }
        }
        cout << answer;
        return 0;
    }