iosnsinvocationarm64

EXC_BAD_ACCESS crash on arm64 when use NSInvocation


I've begun prepare one old project to support arm64 architecture. But when I try to execute this code on 64 bit device I get EXC_BAD_ACCESS crash on [invocation retainArguments]; line

- (void)makeObjectsPerformSelector: (SEL)selector withArguments: (void*)arg1, ...
{

    va_list argList;

    NSArray* currObjects = [NSArray arrayWithArray: self];
    for (id object in currObjects)
    {
        if ([object respondsToSelector: selector])
        {
            NSMethodSignature* signature = [[object class] instanceMethodSignatureForSelector: selector];

            NSInvocation* invocation = [NSInvocation invocationWithMethodSignature: signature];
            invocation.selector = selector;
            invocation.target = object;

            if (arg1 != nil)
            {
                va_start(argList, arg1);

                char* arg = arg1;

                for (int i = 2; i < signature.numberOfArguments; i++)
                {
                    const char* type = [signature getArgumentTypeAtIndex: i];
                    NSUInteger size, align;
                    NSGetSizeAndAlignment(type, &size, &align);
                    NSUInteger mod = (NSUInteger) arg % align;

                    if (mod != 0)
                        arg += (align - mod);

                    [invocation setArgument: arg
                                    atIndex: i];

                    arg = (i == 2) ? (char*) argList : (arg + size);
                }

                va_end(argList);
            }

            [invocation retainArguments];
            [invocation invoke];
        }
    }
}

It seems like its some problem with arguments.


Solution

  • This is what have for the same purposes.

    + (void)callSelectorWithVarArgs:(SEL)selector onTarget:(id)target onThread:(id)thread wait:(BOOL)wait, ...
    {
        NSMethodSignature *aSignature = [[target class] instanceMethodSignatureForSelector:selector];
    
        if (aSignature)
        {
            NSInvocation *anInvocation = [NSInvocation invocationWithMethodSignature:aSignature];
            void *        arg;
            int           index = 2;
    
            [anInvocation setSelector:selector];
            [anInvocation setTarget:target];
    
            va_list       args;
            va_start(args, wait);
    
            do
            {
                arg = va_arg(args, void *);
                if (arg)
                {
                    [anInvocation setArgument:arg atIndex:index++];
                }
            }
            while (arg);
    
            va_end(args);
    
            [anInvocation retainArguments];
    
            if (thread == nil)
            {
                [anInvocation performSelectorOnMainThread:@selector(invoke) withObject:nil waitUntilDone:wait];
            }
            else
            {
                [anInvocation performSelector:@selector(invoke) onThread:thread withObject:nil waitUntilDone:wait];
            }
        }
    }
    

    Please take into account, that this code is potentially unsafe with when necessary to perform type conversion. When invoked method has longer argument that was passed to my callSelectorWithVarArgs:onTarget:onThread:wait: (for example, invoked method receives NSUInteger (which is 64bit on arm64) but i pass int (which is 32bit on both arm and arm64)), that causes read of 64 bit from start address of 32bit variable - and trash in data). Anyway, your implementation is potentially dangerous - you treat all arguments passed to wrapped method as having the same types as arguments in invoked method.

    This is your modified code that works:

    - (void)makeObjectsPerformSelector:(SEL)selector withArguments: (void*)arg1, ...
    {
        NSArray* currObjects = [NSArray arrayWithArray: self];
        for (id object in currObjects)
        {
            if ([object respondsToSelector: selector])
            {
                NSMethodSignature* signature = [[object class] instanceMethodSignatureForSelector: selector];
    
                NSInvocation* invocation = [NSInvocation invocationWithMethodSignature: signature];
                invocation.selector = selector;
                invocation.target = object;
    
                [invocation setArgument:&arg1 atIndex:2];
    
                NSInteger   index = 3;
                void *        arg;
    
                va_list       args;
                va_start(args, arg1);
    
                do
                {
                    arg = va_arg(args, void *);
                    if (arg)
                    {
                        [invocation setArgument:&arg atIndex:index++];
                    }
                }
                while (arg);
    
                va_end(args);
    
                [invocation retainArguments];
                [invocation invoke];
            }
        }
    }