javajsonjacksonjackson-modulesjackson-dataformat-xml

JsonMappingException: No suitable constructor found for type [simple type, class car.Car$Parts]


I'm trying to deserialize this XML into a Parts object:

<Parts>
    <Part>
                <Name>gearbox</Name>
                <Year>1990</Year>
    </Part>
    <Part>
                <Name>wheel</Name>
                <Year>2000</Year>
    </Part>
</Parts>

Car.java:

package problem.car;

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
import java.io.IOException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

public class Car {

    @JsonInclude(JsonInclude.Include.NON_NULL)
    @JsonPropertyOrder({
        "Parts"
    })
    public class Parts {

        @JsonProperty("parts")
        private List<Part> parts = new ArrayList<>();

        @JsonProperty("parts")
        public List<Part> getParts() {
            return parts;
        }

        @JsonProperty("parts")
        public void setParts(List<Part> parts) {
            this.parts = parts;
        }

    }

    @JsonInclude(JsonInclude.Include.NON_NULL)
    @JsonPropertyOrder({
        "Name",
        "Year"
    })
    public class Part {

        @JsonProperty("Name")
        private String Name;
        @JsonProperty("Year")
        private String Year;

        @JsonProperty("Name")
        public String getName() {
            return Name;
        }

        @JsonProperty("Name")
        public void setName(String Name) {
            this.Name = Name;
        }

        @JsonProperty("Year")
        public String getYear() {
            return Year;
        }

        @JsonProperty("Year")
        public void setYear(String Year) {
            this.Year = Year;
        }

    }

    public static void main(String args[]) {
        try {
            String xml = "<Parts>\n"
                    + " <Part>\n"
                    + "             <Name>gearbox</Name>\n"
                    + "             <Year>1990</Year>\n"
                    + " </Part>\n"
                    + " <Part>\n"
                    + "             <Name>wheel</Name>\n"
                    + "             <Year>2000</Year>\n"
                    + " </Part>\n"
                    + "</Parts>";
          Parts parts = (Parts) deserialize(Parts.class, xml);

        } catch (IOException ex) {
            Logger.getLogger(Car.class.getName()).log(Level.SEVERE, null, ex);
        }
    }

    public static final Object deserialize(final Class clazz, final String xml) throws IOException {
        ObjectMapper xmlMapper = new XmlMapper();
        xmlMapper.setDateFormat(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssz"));
        Object object;
        try {
            object = xmlMapper.readValue(xml, clazz);
        } catch (com.fasterxml.jackson.databind.exc.InvalidFormatException ex) {
            xmlMapper.setDateFormat(new SimpleDateFormat("yyyy-MM-dd"));
            object = xmlMapper.readValue(xml, clazz);
        }
        return object;
    }
}

I don't see anything wrong with my code though so why does it keep giving me the following?

com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class problem.car.Car$Parts]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?)

Solution

  • The answer

    The Part class is a nested, non-static class. In order to instantiate it, you must have an instance of the outer class.

    Here is an inner class tutorial

    I-hate-reading answer

    Move the Part and Parts classes to their own java files, named Part.java and Parts.java.