On an show user action, i want to check if the logged user has the right to see this user. So i created a UserVoter.
But when I try to pass the user defined in the url to the Voter using annotation, I get the logged User using both $subject
and $token->getUser()
If I change my var name in the action, it works fine ($user -> $foo).
Do you know how can I do for not changing my var name ?
Controller :
/**
* Finds and displays a user entity.
*
* @Method("GET")
* @Route("/{id}/", name="authenticated_user_show", requirements={"id": "\d+"})
* @ParamConverter("user", class="AppBundle:User")
* @Security("is_granted('SHOW', user)")
*/
public function showAction(User $user)
{
And Voter :
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
$user = $token->getUser();
if (!$user instanceof User) {
// the user must be logged in; if not, deny access
return false;
}
if ($user->hasRole(User::ROLE_SUPER_ADMIN)) {
// if super admin, can do everything
return true;
}
// you know $subject is an User object, thanks to supports
/** @var User $userSubject */
$userSubject = $subject;
switch ($attribute) {
case self::SHOW:
return $this->canShow($userSubject, $user);
case self::EDIT:
return $this->canEdit($userSubject, $user);
}
throw new \LogicException('This code should not be reached!');
}
private function canShow(User $userSubject, User $user) : bool
{
if ($user->getClient() === $userSubject->getClient()) {
// if they are in the same client
return true;
}
return false;
}
private function canEdit(User $userSubject, User $user, TokenInterface $token) : bool
{
if (
$this->decisionManager->decide($token, [User::ROLE_ADMIN]) &&
$user->getClient() === $userSubject->getClient()
) {
// if the user and the admin belong to the same client
return true;
} elseif (
$this->decisionManager->decide($token, [User::ROLE_MANAGER]) &&
$this->userManager->hasEstablishmentInCommon($user, $userSubject)
) {
// if the user and the manager are linked to the same establishment
return true;
}
return false;
}
Assuming that you are not trying to see the logged user I will consider that you may have a conflict with the variables in the security annotation context:
https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/security.html The Security annotation has access to the following variables:
To fix, change the name of the user so you can avoid the conflict.
/**
* Finds and displays a user entity.
*
* @Method("GET")
* @Route("/{id}/", name="authenticated_user_show", requirements={"id":
"\d+"})
* @ParamConverter("showUser", class="AppBundle:User")
* @Security("is_granted('SHOW', showUser)")
*/
public function showAction(User $showUser)