I noticed that the builds on our CI started to fail because of the following error:
Discovered plugin "cordova-plugin-app-version" in config.xml. Adding it to the project
Installing "cordova-plugin-app-version" for android
Adding cordova-plugin-app-version to package.json
Using "requireCordovaModule" to load non-cordova module "q" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.
[ERROR] Exception:
The command '/bin/sh -c ionic cordova platforms add android' returned a non-zero code: 1
Same issue happens on both iOS and Android.
After some digging, I found that cordova 9.0.0 was recently released.
There are a couple of changes related to this issue.
My first thought was that somehow we didn't have our cordova version locked, but we did lock it to cordova@8.1.2 in our dockerfile. I also tested it on my local machine and I cordova version 8.1.2 as well. So this can't be the issue.
After looking at the logs some more, I noticed some logs like these:
cordova-android version check failed ("/app/platforms/android/cordova/version"), continuing anyways.
There were a couple of those, like 3 or 4, but the build did not stop when that happened.
I then ran the build of an older commit again, and it worked fine, probably because some layers were cached. But if I changed only a single package (I updated prettier to try it out), it caused most of the layers to be rebuilt and the build crashed with the above error.
It seems that somehow some dependencies deeper down got updated, which are causing the issue.
Thanks for your help.
I ran into this also. In my case, I needed to remove a problematic plugin cordova-plugin-camera-preview which lists "cordova": "*" as a dependency. This would install cordova 9.0.0 during ionic cordova build