I am trying to change some of my code pretty drastically. Everywhere where I am using a widely used struct in a module port signature, I would like to replace with a interface (if appropriate).
One logical operation that I have not figured out is a collapsing & or and collapsing or.
This is very easy to do with a regular vector of bits: Somewhere in a module I can very easily perform collapsing & and |
logic [31:0] vect ;
logic my_sig_and ;
logic my_sig_or ;
always_comb begin
my_sig_and = &vect ;
my_sig_or = |vect ;
end
My attempts are below (even the silly ones):
interface myInterface () () ;
logic valid
logic[31:0] data
endinterface
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = my_intfs[0].ready ;
for( genvar ii = 1; ii < PORTS; ii++ ) begin
temp_signal = temp_signal && my_intfs[ii].ready ; // error line
end
end
always_comb begin
my_sig_and = temp_signal;
end
Error: near "genvar": syntax error, unexpected genvar, expecting ';'.
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = my_intfs[0].ready ;
for( int ii = 1; ii < PORTS; ii++ ) begin
temp_signal = temp_signal && my_intfs[ii].ready ; // error line
end
end
always_comb begin
my_sig_and = temp_signal;
end
Error: Nonconstant index into instance array 'my_intfs'
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = my_intfs[0].ready ;
for( int ii = 1; ii < PORTS; ii++ ) begin
temp_signal = temp_signal && my_intfs[ii+:0].ready ; // error line
end
end
always_comb begin
my_sig_and = temp_signal;
end
(vlog-13172) Selected name after a part-select may only be a modport on an interface port.
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = my_intfs[0].ready ;
end
for( genvar ii = 1; ii < PORTS; ii++ ) begin
always_comb begin
temp_signal = temp_signal && my_intfs[ii].ready ; // error line
end
end
always_comb begin
my_sig_and = temp_signal;
end
(vopt-7033) Variable 'temp_signal' driven in a combinational block, may not be driven by any other process
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
for( genvar ii = 0; ii < PORTS; ii++ ) begin
always_comb begin
temp_signal = temp_signal && my_intfs[ii].ready ; // error line
end
end
always_comb begin
my_sig_and = temp_signal;
end
(vopt-7033) Variable 'temp_signal' driven in a combinational block, may not be driven by any other process.
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = &my_intfs.ready ; // error line
end
always_comb begin
my_sig_and = temp_signal;
end
(vopt-2990) Illegal operation on unpacked type.
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = my_intfs.&ready ; // error line
end
always_comb begin
my_sig_and = temp_signal;
end
near "&": syntax error, unexpected '&'
My attempt somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
always_comb begin
temp_signal = &my_intfs[@].ready ; // error line
end
always_comb begin
my_sig_and = temp_signal;
end
near "@": syntax error, unexpected '@'.
Using a macro that assigns all interface array elements to a placeholder logic vector worked. Simply collapse the logic vector after all of the assignments are complete.:
somewhere in a module:
myInterface () my_intfs [PORTS-1:0] () ; // assume this is assigned to
logic temp_signal ;
logic my_sig_and ;
`INTF_FIELD_COLLAPSE_AND( blah, my_intfs, valid, PORTS, 1, my_sig_and )
`ifndef INTF_FIELD_COLLAPSE_AND
`define INTF_FIELD_COLLAPSE_AND( unique, intf, field, size, field_size, output_sig ) \
logic [size-1:0] [field_size-1:0] my_sig_unique ; \
for( genvar ii_unique = 0; ii_unique < PORTS; ii_unique++ ) begin \
always_comb begin \
my_sig_unique[ii_unique] = intf[ii_unique].field ; \
end \
end \
output_sig = &my_sig_unique ;
`endif